Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workgroup support for Athena named query #9383

Merged
merged 3 commits into from
Jul 18, 2019

Conversation

paulhudson
Copy link
Contributor

@paulhudson paulhudson commented Jul 17, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8016

Release note for CHANGELOG:

Adds optional `workgroup` argument to athena_named_query resource.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAthenaNamedQuery'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAthenaNamedQuery -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAthenaNamedQuery_basic
=== PAUSE TestAccAWSAthenaNamedQuery_basic
=== RUN   TestAccAWSAthenaNamedQuery_withWorkGroup
=== PAUSE TestAccAWSAthenaNamedQuery_withWorkGroup
=== RUN   TestAccAWSAthenaNamedQuery_import
=== PAUSE TestAccAWSAthenaNamedQuery_import
=== CONT  TestAccAWSAthenaNamedQuery_basic
=== CONT  TestAccAWSAthenaNamedQuery_import
=== CONT  TestAccAWSAthenaNamedQuery_withWorkGroup
--- PASS: TestAccAWSAthenaNamedQuery_basic (81.90s)
--- PASS: TestAccAWSAthenaNamedQuery_withWorkGroup (82.52s)
--- PASS: TestAccAWSAthenaNamedQuery_import (85.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.186s

@paulhudson paulhudson requested a review from a team July 17, 2019 12:31
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/athena Issues and PRs that pertain to the athena service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 17, 2019
@paulhudson paulhudson force-pushed the f-aws-resource-athena-named-query branch from 63bc10c to 9a5add9 Compare July 17, 2019 13:44
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulhudson 👋 Thanks for contributing this. Its off to a good start, just a few little things and we should be able to get this in. Please reach out if you have any questions or do not have time to implement the feedback.

aws/resource_aws_athena_named_query_test.go Outdated Show resolved Hide resolved
aws/resource_aws_athena_named_query_test.go Show resolved Hide resolved
website/docs/r/athena_named_query.html.markdown Outdated Show resolved Hide resolved
website/docs/r/athena_named_query.html.markdown Outdated Show resolved Hide resolved
website/docs/r/athena_named_query.html.markdown Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Jul 18, 2019
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 18, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jul 18, 2019
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 18, 2019
@bflad bflad self-requested a review July 18, 2019 13:59
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for those updates as they helped uncover a regression that could have been merged in. Please see the below two small items to fix this up and once the acceptance testing is passing again this is good to go. Thanks!

aws/resource_aws_athena_named_query.go Show resolved Hide resolved
website/docs/r/athena_named_query.html.markdown Outdated Show resolved Hide resolved
@paulhudson paulhudson force-pushed the f-aws-resource-athena-named-query branch from 0500716 to e016e15 Compare July 18, 2019 14:31
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks, @paulhudson 🚀

--- PASS: TestAccAWSAthenaNamedQuery_withWorkGroup (25.40s)
--- PASS: TestAccAWSAthenaNamedQuery_basic (25.47s)
--- PASS: TestAccAWSAthenaNamedQuery_import (25.83s)

@bflad bflad added this to the v2.20.0 milestone Jul 18, 2019
@bflad bflad merged commit 7e7ece6 into hashicorp:master Jul 18, 2019
bflad added a commit that referenced this pull request Jul 18, 2019
@nywilken
Copy link
Contributor

The enhancement to the aws_athena_named_query resource, has been released in version 2.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks!

@paulhudson paulhudson deleted the f-aws-resource-athena-named-query branch July 22, 2019 10:03
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_athena_named_query resource support for workgroup
3 participants