Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries for config timeouts #9438

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Final retries for config timeouts #9438

merged 1 commit into from
Jul 24, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Related #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_config_config_rule: Retries after timeouts when creating and deleting config rules
* resource/aws_config_delivery_channel: Retries after timeouts when creating and deleting config delivery channels

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSConfig/Config$" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSConfig/Config -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSConfig
=== RUN   TestAccAWSConfig/Config
=== RUN   TestAccAWSConfig/Config/basic
=== RUN   TestAccAWSConfig/Config/ownerAws
=== RUN   TestAccAWSConfig/Config/customlambda
=== RUN   TestAccAWSConfig/Config/importAws
=== RUN   TestAccAWSConfig/Config/importLambda
=== RUN   TestAccAWSConfig/Config/scopeTagKey
=== RUN   TestAccAWSConfig/Config/scopeTagKeyEmpty
=== RUN   TestAccAWSConfig/Config/scopeTagValue
--- PASS: TestAccAWSConfig (1481.00s)
    --- PASS: TestAccAWSConfig/Config (963.09s)
        --- PASS: TestAccAWSConfig/Config/basic (103.54s)
        --- PASS: TestAccAWSConfig/Config/ownerAws (103.12s)
        --- PASS: TestAccAWSConfig/Config/customlambda (147.18s)
        --- PASS: TestAccAWSConfig/Config/importAws (104.68s)
        --- PASS: TestAccAWSConfig/Config/importLambda (141.80s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKey (129.85s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKeyEmpty (106.40s)
        --- PASS: TestAccAWSConfig/Config/scopeTagValue (126.52s)
    

make testacc TESTARGS="-run=TestAccAWSConfig/DeliveryChannel" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSConfig/DeliveryChannel -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSConfigAggregateAuthorization_basic
=== PAUSE TestAccAWSConfigAggregateAuthorization_basic
=== RUN   TestAccAWSConfigConfigurationAggregator_account
=== PAUSE TestAccAWSConfigConfigurationAggregator_account
=== RUN   TestAccAWSConfigConfigurationAggregator_organization
=== PAUSE TestAccAWSConfigConfigurationAggregator_organization
=== RUN   TestAccAWSConfigConfigurationAggregator_switch
=== PAUSE TestAccAWSConfigConfigurationAggregator_switch
=== RUN   TestAccAWSConfig
=== RUN   TestAccAWSConfig/DeliveryChannel
=== RUN   TestAccAWSConfig/DeliveryChannel/allParams
=== RUN   TestAccAWSConfig/DeliveryChannel/importBasic
=== RUN   TestAccAWSConfig/DeliveryChannel/basic
--- PASS: TestAccAWSConfig (213.97s)
    --- PASS: TestAccAWSConfig/DeliveryChannel (213.97s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/allParams (73.99s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/importBasic (69.31s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/basic (70.67s)
=== CONT  TestAccAWSConfigAggregateAuthorization_basic
=== CONT  TestAccAWSConfigConfigurationAggregator_organization
=== CONT  TestAccAWSConfigConfigurationAggregator_account
=== CONT  TestAccAWSConfigConfigurationAggregator_switch
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (2.64s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (2.65s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccAWSConfigAggregateAuthorization_basic (24.91s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (28.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       243.272s

@ryndaniels ryndaniels requested a review from a team July 22, 2019 16:37
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/configservice Issues and PRs that pertain to the configservice service. labels Jul 22, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Jul 23, 2019
@bflad bflad added this to the v2.21.0 milestone Jul 23, 2019
bflad
bflad approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSConfig (1312.48s)
    --- PASS: TestAccAWSConfig/DeliveryChannel (141.47s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/basic (47.10s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/allParams (46.41s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/importBasic (47.96s)
    --- PASS: TestAccAWSConfig/Config (844.60s)
        --- PASS: TestAccAWSConfig/Config/importAws (94.53s)
        --- PASS: TestAccAWSConfig/Config/importLambda (131.61s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKey (114.74s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKeyEmpty (95.35s)
        --- PASS: TestAccAWSConfig/Config/scopeTagValue (106.27s)
        --- PASS: TestAccAWSConfig/Config/basic (92.46s)
        --- PASS: TestAccAWSConfig/Config/ownerAws (93.63s)
        --- PASS: TestAccAWSConfig/Config/customlambda (116.01s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus (190.60s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/basic (48.18s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/startEnabled (94.92s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/importBasic (47.49s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorder (135.80s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/importBasic (46.94s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/basic (44.06s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/allParams (44.80s)
=== CONT  TestAccAWSConfigAggregateAuthorization_basic
=== CONT  TestAccAWSConfigConfigurationAggregator_switch
=== CONT  TestAccAWSConfigConfigurationAggregator_organization
=== CONT  TestAccAWSConfigConfigurationAggregator_account
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (1.35s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (1.35s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccAWSConfigAggregateAuthorization_basic (13.55s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (15.20s)
PASS

@ryndaniels ryndaniels merged commit 81e453b into master Jul 24, 2019
@ryndaniels ryndaniels deleted the rfd-retry-config branch July 24, 2019 09:54
@ryndaniels ryndaniels restored the rfd-retry-config branch July 24, 2019 10:36
@ryndaniels ryndaniels deleted the rfd-retry-config branch July 24, 2019 13:14
@bflad
Copy link
Contributor

bflad commented Jul 26, 2019

This has been released in version 2.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests, documentation updates, or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/configservice Issues and PRs that pertain to the configservice service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad