-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source for aws_ssm_patch_baseline #9486
Conversation
I appreciate you may be busy @bflad and team, the PR has been open for 3 months now. Is there anything I can do to help this get merged? |
Hi @jdheyburn! Thanks for working on this. You'll need to back out the CHANGELOG addition -- that's something the person who merges will take care of so there aren't conflicts. |
Apologies - I've reverted the change to the CHANGELOG and updated the imports as it looks like they've changed since the PR was opened. |
Hey folks - let me know if there's anything else needed to get this forward, I appreciate the time taken to review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jdheyburn 👋 Thank you for submitting this and apologies for the delayed review. Overall this is looking pretty good, just a few items and this should be good to go. Please reach out if you have any questions or do not have time to implement them. 👍
Apologies for several commits - doesn't look like the markdown was in the correct location for it to be picked up by docscheck. My branch is now so far behind it keeps missing all the new checks 😅 Let me know any further suggestions you might have 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those updates, @jdheyburn, looks good to me 🚀
Output from acceptance testing:
--- PASS: TestAccAWSSsmPatchBaselineDataSource_existingBaseline (8.36s)
--- PASS: TestAccAWSSsmPatchBaselineDataSource_newBaseline (8.76s)
This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #5116
Release note for CHANGELOG:
Output from acceptance testing: