Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support resource tags for configservice #9561

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Add support resource tags for configservice #9561

merged 6 commits into from
Jul 31, 2019

Conversation

teraken0509
Copy link
Contributor

@teraken0509 teraken0509 commented Jul 31, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9353

Release note for CHANGELOG:

resource/aws_config_config_rule: support tags attribute
resource/aws_config_configuration_aggregator: support tags attribute
resource/aws_config_aggregate_authorization : support tags attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSConfig -timeout 120m
=== RUN   TestAccAWSConfigAggregateAuthorization_basic
=== PAUSE TestAccAWSConfigAggregateAuthorization_basic
=== RUN   TestAccAWSConfigAggregateAuthorization_tags
=== PAUSE TestAccAWSConfigAggregateAuthorization_tags
=== RUN   TestAccAWSConfigConfigurationAggregator_account
=== PAUSE TestAccAWSConfigConfigurationAggregator_account
=== RUN   TestAccAWSConfigConfigurationAggregator_organization
=== PAUSE TestAccAWSConfigConfigurationAggregator_organization
=== RUN   TestAccAWSConfigConfigurationAggregator_switch
=== PAUSE TestAccAWSConfigConfigurationAggregator_switch
=== RUN   TestAccAWSConfigConfigurationAggregator_tags
=== PAUSE TestAccAWSConfigConfigurationAggregator_tags
=== RUN   TestAccAWSConfig
=== RUN   TestAccAWSConfig/Config
=== RUN   TestAccAWSConfig/Config/scopeTagKeyEmpty
=== RUN   TestAccAWSConfig/Config/scopeTagValue
=== RUN   TestAccAWSConfig/Config/tags
=== RUN   TestAccAWSConfig/Config/basic
=== RUN   TestAccAWSConfig/Config/ownerAws
=== RUN   TestAccAWSConfig/Config/customlambda
=== RUN   TestAccAWSConfig/Config/importAws
=== RUN   TestAccAWSConfig/Config/importLambda
=== RUN   TestAccAWSConfig/Config/scopeTagKey
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/basic
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/startEnabled
=== RUN   TestAccAWSConfig/ConfigurationRecorderStatus/importBasic
=== RUN   TestAccAWSConfig/ConfigurationRecorder
=== RUN   TestAccAWSConfig/ConfigurationRecorder/basic
=== RUN   TestAccAWSConfig/ConfigurationRecorder/allParams
=== RUN   TestAccAWSConfig/ConfigurationRecorder/importBasic
=== RUN   TestAccAWSConfig/DeliveryChannel
=== RUN   TestAccAWSConfig/DeliveryChannel/basic
=== RUN   TestAccAWSConfig/DeliveryChannel/allParams
=== RUN   TestAccAWSConfig/DeliveryChannel/importBasic
--- PASS: TestAccAWSConfig (1881.97s)
    --- PASS: TestAccAWSConfig/Config (1233.67s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKeyEmpty (122.98s)
        --- PASS: TestAccAWSConfig/Config/scopeTagValue (142.01s)
        --- PASS: TestAccAWSConfig/Config/tags (171.49s)
        --- PASS: TestAccAWSConfig/Config/basic (120.07s)
        --- PASS: TestAccAWSConfig/Config/ownerAws (119.95s)
        --- PASS: TestAccAWSConfig/Config/customlambda (145.95s)
        --- PASS: TestAccAWSConfig/Config/importAws (119.98s)
        --- PASS: TestAccAWSConfig/Config/importLambda (148.99s)
        --- PASS: TestAccAWSConfig/Config/scopeTagKey (142.25s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus (268.93s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/basic (64.79s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/startEnabled (137.50s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorderStatus/importBasic (66.64s)
    --- PASS: TestAccAWSConfig/ConfigurationRecorder (193.25s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/basic (64.20s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/allParams (63.88s)
        --- PASS: TestAccAWSConfig/ConfigurationRecorder/importBasic (65.17s)
    --- PASS: TestAccAWSConfig/DeliveryChannel (186.12s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/basic (63.05s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/allParams (62.62s)
        --- PASS: TestAccAWSConfig/DeliveryChannel/importBasic (60.45s)
=== CONT  TestAccAWSConfigAggregateAuthorization_basic
=== CONT  TestAccAWSConfigConfigurationAggregator_account
=== CONT  TestAccAWSConfigConfigurationAggregator_switch
=== CONT  TestAccAWSConfigConfigurationAggregator_tags
=== CONT  TestAccAWSConfigConfigurationAggregator_organization
=== CONT  TestAccAWSConfigAggregateAuthorization_tags
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (3.38s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (3.39s)
    provider_test.go:247: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- PASS: TestAccAWSConfigAggregateAuthorization_basic (31.60s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (35.99s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (70.54s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (85.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1967.740s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/configservice Issues and PRs that pertain to the configservice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 31, 2019
@teraken0509 teraken0509 marked this pull request as ready for review July 31, 2019 06:00
@teraken0509 teraken0509 requested a review from a team July 31, 2019 06:00
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 31, 2019
@bflad bflad self-assigned this Jul 31, 2019
@bflad bflad added this to the v2.22.0 milestone Jul 31, 2019
bflad
bflad approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @kterada0509 🚀

--- PASS: TestAccAWSConfigAggregateAuthorization_basic (8.48s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (9.23s)
--- PASS: TestAccAWSConfigAggregateAuthorization_tags (18.02s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (21.68s)
--- PASS: TestAccAWSConfig (1093.69s)

@bflad bflad merged commit ffedf5e into hashicorp:master Jul 31, 2019
bflad added a commit that referenced this pull request Jul 31, 2019
@bflad
Update CHANGELOG for #9561
6c71019
@ghost
Copy link

ghost commented Aug 1, 2019

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@teraken0509 teraken0509 deleted the feature/add-support-resource-tags-for-configservice branch March 5, 2020 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/configservice Issues and PRs that pertain to the configservice service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.

Add support for tagging of AWS Config resources
2 participants
@teraken0509 @bflad