Final retries after datasync resource timeout errors

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_datasync_agent: Final retries after timeouts creating datasync agent
* resource/aws_datasync_task: Final retry after timeout error creating datasync task

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDataSyncAgent"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDataSyncAgent -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDataSyncAgent_basic
=== PAUSE TestAccAWSDataSyncAgent_basic
=== RUN   TestAccAWSDataSyncAgent_disappears
=== PAUSE TestAccAWSDataSyncAgent_disappears
=== RUN   TestAccAWSDataSyncAgent_AgentName
=== PAUSE TestAccAWSDataSyncAgent_AgentName
=== RUN   TestAccAWSDataSyncAgent_Tags
=== PAUSE TestAccAWSDataSyncAgent_Tags
=== CONT  TestAccAWSDataSyncAgent_basic
=== CONT  TestAccAWSDataSyncAgent_Tags
=== CONT  TestAccAWSDataSyncAgent_disappears
=== CONT  TestAccAWSDataSyncAgent_AgentName
--- PASS: TestAccAWSDataSyncAgent_disappears (213.36s)
--- PASS: TestAccAWSDataSyncAgent_basic (238.26s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (254.93s)
--- PASS: TestAccAWSDataSyncAgent_Tags (310.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       312.021s

make testacc TESTARGS="-run=TestAccAWSDataSyncTask"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDataSyncTask -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== RUN   TestAccAWSDataSyncTask_disappears
=== PAUSE TestAccAWSDataSyncTask_disappears
=== RUN   TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== PAUSE TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== RUN   TestAccAWSDataSyncTask_Tags
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
    resource_aws_datasync_task_test.go:460: Tagging on creation is inconsistent
=== CONT  TestAccAWSDataSyncTask_basic
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== CONT  TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== CONT  TestAccAWSDataSyncTask_disappears
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
--- PASS: TestAccAWSDataSyncTask_disappears (288.40s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (544.45s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (563.63s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (591.44s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (592.86s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (593.28s)
--- PASS: TestAccAWSDataSyncTask_basic (593.88s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (594.44s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (600.14s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (600.42s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (616.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       617.601s

[bflad]

LGTM 🚀

--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
--- PASS: TestAccAWSDataSyncAgent_disappears (146.31s)
--- PASS: TestAccAWSDataSyncAgent_basic (150.01s)
--- PASS: TestAccAWSDataSyncAgent_AgentName (163.94s)
--- PASS: TestAccAWSDataSyncAgent_Tags (172.29s)
--- PASS: TestAccAWSDataSyncTask_disappears (188.66s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (423.65s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (447.37s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (479.74s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (480.91s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (488.51s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (500.04s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (501.41s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (519.69s)
--- PASS: TestAccAWSDataSyncTask_basic (528.36s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (540.66s)

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!