Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: enable specifying metadata for app and SP passwords #444

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Bugfix: enable specifying metadata for app and SP passwords #444

merged 1 commit into from
Jun 8, 2021

Conversation

manicminer
Copy link
Contributor

  • Can now set display_name, start_date, end_date and end_date_relative
  • Update Hamilton for this, and another fix to mitigate access token refresh race

@manicminer
Bugfix: enable specifying metadata for app and SP passwords
d7e3680 
- Can now set display_name, start_date, end_date and end_date_relative
- Update Hamilton for this, and another fix to mitigate access token refresh race
@manicminer manicminer added this to the v1.5.1 milestone May 27, 2021
@manicminer manicminer requested a review from a team May 27, 2021 23:58
@manicminer
Copy link
Contributor Author

Fixes #447

@manicminer manicminer linked an issue Jun 1, 2021 that may be closed by this pull request
azuread_application_password start/end date #447
Closed
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-06-08 at 01 09 39

Screenshot 2021-06-08 at 01 09 50

katbyte
katbyte approved these changes Jun 8, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@manicminer manicminer merged commit fab2d66 into main Jun 8, 2021
@manicminer manicminer deleted the bugfix/app-sp-password-metadata branch June 8, 2021 22:00
manicminer added a commit that referenced this pull request Jun 8, 2021
@manicminer
Changelog for #444
2c836d2
@github-actions
Copy link

This functionality has been released in v1.5.1 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

romainDavaze pushed a commit to romainDavaze/terraform-provider-azuread that referenced this pull request Jul 5, 2021
@manicminer @romainDavaze
Changelog for hashicorp#444
42ed906
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
api/microsoft-graph bug feature/applications feature/service-principals
Projects
None yet
Milestone
v1.5.1
Development

Successfully merging this pull request may close these issues.

azuread_application_password start/end date
2 participants
@manicminer @katbyte