Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azuread_invitation resource #445

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

romainDavaze
Copy link
Contributor

@romainDavaze romainDavaze commented May 28, 2021

Implementing azuread_invitation resource to invite guest users.

Acceptance tests may not pass because of a timing issue between the creation of the guest user and its deletion.

This is issue is addressed here. Ideally, we need to wait for this PR to be merged in order to make these tests pass.

@manicminer manicminer added this to the v2.0.0 milestone Jun 1, 2021
@romainDavaze romainDavaze force-pushed the feature/invitations branch 3 times, most recently from 862e58e to 5c4f41f Compare June 9, 2021 07:45
@romainDavaze romainDavaze force-pushed the feature/invitations branch 2 times, most recently from 4084ed0 to 5c4f41f Compare July 5, 2021 14:51
@manicminer manicminer modified the milestones: v2.0.0, v2.1.0 Jul 6, 2021
@manicminer manicminer linked an issue Jul 21, 2021 that may be closed by this pull request
@manicminer
Copy link
Member

Rebased to resolve conflicts, updated resource and docs to dry it out a bit and add the user_type property, along with some more tests.

Thanks @romainDavaze for this implementation!

@manicminer manicminer requested a review from a team September 2, 2021 17:31
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed internally LGTM 🙌

@manicminer
Copy link
Member

Thanks @katbyte! 🍕

Test results:

Screenshot 2021-09-02 at 18 46 01

@manicminer manicminer merged commit 38e87da into hashicorp:main Sep 2, 2021
manicminer added a commit that referenced this pull request Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support guest user invitations
3 participants