Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Principal improvements #481

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jul 13, 2021

  • Upgrade Hamilton to v0.22.0

Note: This PR currently targets f/user-group-improvements since there are dependent changes in there - once that PR is merged this can go to main

Bug fixes

  • azuread_application - identifier_uris is now a TypeSet (was TypeList) [breaking change]
  • azuread_application - fix a bug parsing the implicit_grant block

Applications

  • New data source: azuread_application_published_app_ids
  • azuread_application_password - support the keepers property

Service Principals

  • azuread_service_principal - support the account_enabled field
  • azuread_service_principal - support the alternative_names field
  • azuread_service_principal - support the description field
  • azuread_service_principal - support the login_url field
  • azuread_service_principal - support the notes field
  • azuread_service_principal - support the notification_email_addresses field
  • azuread_service_principal - support the preferred_single_sign_on_mode field
  • azuread_service_principal - support the use_existing field
  • azuread_service_principal - export the app_role_ids and oauth2_permission_scope_ids attributes
  • azuread_service_principal - export the application_tenant_id attribute
  • azuread_service_principal - export the display_name attribute
  • azuread_service_principal - export the homepage_url attribute
  • azuread_service_principal - export the logout_url attribute
  • azuread_service_principal - export the redirect_uris attribute
  • azuread_service_principal - export the saml_metadata_url attribute
  • azuread_service_principal - export the service_principal_names attribute
  • azuread_service_principal - export the sign_in_audience attribute
  • azuread_service_principal - export the type attribute
  • azuread_service_principal_password - support the keepers property

Closes: #480
Possibly closes: #173

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-07-13 at 13 18 55

Screenshot 2021-07-13 at 13 19 03

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

- accept_mapped_claims
- known_client_applications
- requested_access_token_version
**Service Principals**

- Support the `account_enabled` field
- Support the `alternative_names` field
- Support the `description` field
- Support the `login_url` field
- Support the `notes` field
- Support the `notification_email_addresses` field
- Support the `preferred_single_sign_on_mode` field
- Support the `use_existing` field
- Export the `application_tenant_id` attribute
- Export the `display_name` attribute
- Export the `homepage_url` attribute
- Export the `logout_url` attribute
- Export the `redirect_uris` attribute
- Export the `saml_metadata_url` attribute
- Export the `service_principal_names` attribute
- Export the `sign_in_audience` attribute
- Export the `type` attribute

**Applications**

- New data source: `azuread_application_published_app_ids`

**Bug fixes**

- `azuread_application` - `identifier_uris` is now a TypeSet (was TypeList) **Breaking Change**
- `azuread_application` - fix a bug parsing the `implicit_grant` block
@manicminer manicminer force-pushed the f/service-principal-improvements branch from 04f52e4 to 6b43716 Compare July 21, 2021 22:03
Base automatically changed from f/user-group-improvements to main July 21, 2021 22:25
@manicminer manicminer merged commit 5055673 into main Jul 21, 2021
@manicminer manicminer deleted the f/service-principal-improvements branch July 21, 2021 22:34
manicminer added a commit that referenced this pull request Jul 21, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.