Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging and inline client cert authentication #490

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Logging and inline client cert authentication #490

merged 1 commit into from
Jul 22, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jul 21, 2021 •
edited
Loading

  • Update Hamilton to v0.23.1
    • New method signatures throughout to add odata.Query{}
  • Bump plugin SDK version to work with Terraform 1.0.2
  • Implement request and response logging via middleware functions in msgraph.Client{}
  • New feature: client certificate authentication by specifying an inline certificate

@manicminer
Logging and inline client cert authentication
00cada4 
- Update Hamilton to v0.23.1
  - New method signatures throughout to add `odata.Query{}`
- Implement request and response logging via middleware functions in `msgraph.Client{}`
- New feature: client certificate authentication by specifying an inline certificate
@manicminer manicminer added this to the v2.0.0 milestone Jul 21, 2021
@manicminer manicminer requested a review from a team July 21, 2021 22:53
jackofallops
jackofallops approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@manicminer manicminer merged commit ead8144 into main Jul 22, 2021
@manicminer manicminer deleted the f/logging branch July 22, 2021 14:02
manicminer added a commit that referenced this pull request Jul 22, 2021
@manicminer
Changelog for #490
547e63d
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
authentication dependencies provider size/XL
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @jackofallops