Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.azuread_application: match display_name case insensitively #492

Merged
merged 1 commit into from
Jul 22, 2021
Merged

data.azuread_application: match display_name case insensitively #492

merged 1 commit into from
Jul 22, 2021

Conversation

manicminer
Copy link
Contributor

  • Also match some more UUIDs case insensitively as they should be

Fixes: #369

@manicminer manicminer added this to the v2.0.0 milestone Jul 21, 2021
@manicminer manicminer requested a review from a team July 21, 2021 23:51
koikonom
koikonom approved these changes Jul 22, 2021
View reviewed changes
Copy link

@koikonom koikonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manicminer manicminer merged commit 8d8f073 into main Jul 22, 2021
@manicminer manicminer deleted the f/application-data-source-case-insensitivity branch July 22, 2021 14:06
manicminer added a commit that referenced this pull request Jul 22, 2021
@manicminer
Changelog for #492
0f724de
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koikonom koikonom koikonom approved these changes

Assignees
No one assigned
Labels
breaking-change enhancement feature/applications size/XS
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

data (all azuread): should be case insensitive
2 participants
@manicminer @koikonom