Document keepers property for application and service principal passwords

[manicminer]

Closes: #570

[katbyte]

LGTM 🩹

[katbyte]

thou one might argue that "keepers" is a bad name for this property as how does that equate "rotate password when" 🤔

[manicminer]

Yeah it's not the most intuitive name tbf. I took the concept and the naming from the random provider where it seems to be aiming for a generic approach. Totally happy to rename it to something more specific, though I'm struggling to think of anything good :D

[katbyte]

ahh given there is a keeper password manager might be best to change hah, doesn't seem like its a standard term for it? - no reason not to be verbose rotate_password_when_changed ?

[manicminer]

ahh given there is a keeper password manager might be best to change hah, doesn't seem like its a standard term for it? - no reason not to be verbose rotate_password_when_changed ?

Sounds perfect 👌

[manicminer]

@katbyte Have renamed this, do you think we need to support the old property name given that it was undocumented?

[katbyte]

like it! thanks for making that change 🙌 LGTM

[github-actions]

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.