Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azuread_app_role_assignment #584

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

manicminer
Copy link
Member

@manicminer manicminer commented Sep 21, 2021

Depends on: manicminer/hamilton#107

  • New Resource: azuread_app_role_assignment

Closes: #164
Closes: #230
Closes: #459

@manicminer
Copy link
Member Author

manicminer commented Sep 21, 2021

Test results

Screenshot 2021-09-21 at 12 11 48

@manicminer manicminer force-pushed the feature/app-role-assignments branch 5 times, most recently from a0df73d to 3d0c6d3 Compare September 21, 2021 11:20
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one comment LGTM 🏗️

@manicminer manicminer merged commit 3247ffb into main Sep 22, 2021
@manicminer manicminer deleted the feature/app-role-assignments branch September 22, 2021 20:38
manicminer added a commit that referenced this pull request Sep 22, 2021
@github-actions
Copy link

This functionality has been released in v2.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.