Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Administrative Units and their members #672

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Support for Administrative Units and their members #672

merged 3 commits into from
Nov 25, 2021

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Nov 22, 2021 •
edited
Loading

Depends on manicminer/hamilton#124 (requires rebase)

  • New Data Source: azuread_administrative_unit
  • New Resource: azuread_administrative_unit
  • New Resource: azuread_administrative_unit_member

@manicminer manicminer added this to the v2.11.0 milestone Nov 22, 2021
@manicminer manicminer requested a review from a team November 22, 2021 18:52
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2021-11-22 at 18 56 31

katbyte
katbyte approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one small comment LGTM 🏗️

docs/resources/administrative_unit.md Show resolved Hide resolved
@manicminer
Tidy up linting script error message
aa37f5f
@manicminer
Support for Administrative Units
c8da446 
- New data source: azuread_administrative_unit
- New resource: azuread_administrative_unit
- New resource: azuread_administrative_unit_member
@manicminer
azuread_administrative_unit: change visibility to a boolean
4b1db35
@manicminer
Copy link
Contributor Author

Tests still passing

@manicminer manicminer merged commit f7c47c4 into main Nov 25, 2021
@manicminer manicminer deleted the r/administrative-unit branch November 25, 2021 17:04
manicminer added a commit that referenced this pull request Nov 25, 2021
@manicminer
Changelog for #672
e074783
@github-actions
Copy link

This functionality has been released in v2.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
feature/administrative-units new-data-source new-resource size/XL
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @katbyte