Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max staleness prefix for multiple regions and fix documentation #1000

Conversation

azmelanar
Copy link

Hi,

In this PR two fixes:

  • fix in documentation, because key is unknown during planning
    Error: azurerm_cosmosdb_account.cosmosdb: consistency_policy.0: invalid or unknown key: max_staleness
  • increase max_staleness_prefix, because
    The maximum lag must be between 5 seconds and 1 day for accounts with a single region, and between 5 minutes and 1 day for accounts with multiple regions.

Please let me know, if there are any questions.

Thanks

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @azmelanar,

Thank you for noticing this and submitting a fix! Aside from a minor update to the documentation LGTM. I'll get this merged for you shortly 🙂

@katbyte
Copy link
Collaborator

katbyte commented Mar 19, 2018

Tests pass:
screen shot 2018-03-19 at 15 19 40

@katbyte katbyte merged commit a103278 into hashicorp:master Mar 19, 2018
@azmelanar azmelanar deleted the increase_max_staleness_prefix_for_multiple_regions branch March 20, 2018 10:54
katbyte added a commit that referenced this pull request Mar 21, 2018
@lorenyu
Copy link

lorenyu commented Mar 29, 2019

Does it make sense to increate the default values, or to change the example to use a higher value for max staleness? Since the example is across multiple regions, the default of 5 seconds / 100 operations isn't allowed in Azure. People who try out the example would end up seeing this error:

image

@ghost
Copy link

ghost commented Mar 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants