Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway: ignoring the case of GatewaySubnet #1141

Merged
merged 2 commits into from
May 6, 2018

Conversation

YuriyKishchenko
Copy link
Contributor

Azure API allows creation of gateway subnet without specific requirements.
I was able to create Virtual Network Gateways with subnets named gatewaySubnet as well as gatEwaysuBnet

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @YuriyKischenko

Thanks for this PR :)

It'd be good to add an Acceptance Test just to confirm this provisions as expected, but this otherwise LGTM 👍. Terraform's Acceptance Tests consist of two parts: the actual test (here's an example) and the associated Terraform Configuration for that test (example). Providing that passes this should be good to merge :)

@tombuildsstuff tombuildsstuff changed the title Ignore case in gatewaySubnet for azure virtual network gateway azurerm_virtual_network_gateway: ignoring the case of GatewaySubnet May 6, 2018
@tombuildsstuff tombuildsstuff modified the milestones: Soon, 1.5.0 May 6, 2018
@tombuildsstuff
Copy link
Contributor

Tests pass:

screen shot 2018-05-06 at 08 16 35

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @YuriyKischenko

I hope you don't mind but I pushed a commit to add an acceptance test for this, and this now LGTM as the test passes 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit c1bf682 into hashicorp:master May 6, 2018
tombuildsstuff added a commit that referenced this pull request May 6, 2018
@YuriyKishchenko
Copy link
Contributor Author

Thank you 👍

@YuriyKishchenko YuriyKishchenko deleted the gatewaysubnetcase branch May 7, 2018 06:13
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants