-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_virtual_network_gateway
: ignoring the case of GatewaySubnet
#1141
azurerm_virtual_network_gateway
: ignoring the case of GatewaySubnet
#1141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @YuriyKischenko
Thanks for this PR :)
It'd be good to add an Acceptance Test just to confirm this provisions as expected, but this otherwise LGTM 👍. Terraform's Acceptance Tests consist of two parts: the actual test (here's an example) and the associated Terraform Configuration for that test (example). Providing that passes this should be good to merge :)
azurerm_virtual_network_gateway
: ignoring the case of GatewaySubnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @YuriyKischenko
I hope you don't mind but I pushed a commit to add an acceptance test for this, and this now LGTM as the test passes 👍
Thanks!
Thank you 👍 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Azure API allows creation of gateway subnet without specific requirements.
I was able to create Virtual Network Gateways with subnets named gatewaySubnet as well as gatEwaysuBnet