Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of application security groups in a rule to 1 #1587

Merged
merged 4 commits into from
Jul 17, 2018

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented Jul 17, 2018

You get the following error if you try and add more than 1 app security group to a rule

network.SecurityRulesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="NumberOfApplicationSecurityGroupsReferencedInSecurityRuleLimitReached" Message="A security rule may have up to 1
Application Security Group in the source or destination fields. The requested configuration has 2 in the SourceApplicationSecurityGroups field."

Fixes #1346

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-07-17 at 13 58 33

@katbyte
Copy link
Collaborator

katbyte commented Jul 17, 2018

There is a related open issue: #1346

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff
Copy link
Contributor

hi @hbuckle

Just to let you know that is now available in [v1.10 of the AzureRM Provider(https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.10.0/CHANGELOG.md#1100-july-21-2018) - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number Of Application Security Groups Referenced In Security Rule Limit Reached
3 participants