azurerm_lb_probe: backport azurestack review comments #1742
Conversation
| } | ||
| d.Set("load_balancer_rules", load_balancer_rules) |
There was a problem hiding this comment.
Nitpick: This is a trivial case (currently) but best practice when using d.Set() with aggregate types (TypeList, TypeSet, TypeMap), we should perform error checking to prevent issues where the code is not properly able to set the Terraform state. e.g.
if err := d.Set("load_balancer_rules", load_balancer_rules); err != nil {
return fmt.Errorf("error setting load_balancer_rules: %s", err)
}| DiffSuppressFunc: suppress.CaseDifference, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| string(network.ProbeProtocolHTTP), | ||
| string(network.ProbeProtocolHTTPS), |
There was a problem hiding this comment.
Nitpick: We may want to consider adding an acceptance test to cover this new value
|
Tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
backport of issues found in this pr
also explicitly adds
Httpssupport toprotocolproperty.