ServiceBus Namespace: polling for the deletion #1908
Conversation
| @@ -212,10 +213,19 @@ func resourceArmServiceBusNamespaceDelete(d *schema.ResourceData, meta interface | |||
| resourceGroup := id.ResourceGroup | |||
| name := id.Path["namespaces"] | |||
|
|
|||
| _, err = client.Delete(ctx, resourceGroup, name) | |||
| deleteFuture, err := client.Delete(ctx, resourceGroup, name) | |||
There was a problem hiding this comment.
could we call this future to match the rest of the codebase?
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err = deleteFuture.WaitForCompletionRef(ctx, client.Client) | ||
| if err != nil { |
There was a problem hiding this comment.
These lines could be combines as such:
if err := deleteFuture.WaitForCompletionRef(ctx, client.Client); err != nil {| func testAccAzureRMServiceBusNamespace_premium(rInt int, location string) string { | ||
| return fmt.Sprintf(` | ||
| resource "azurerm_resource_group" "test" { | ||
| name = "acctestRG-%d" |
There was a problem hiding this comment.
Could we align these assignments?
| name = "acctestRG-%d" | ||
| location = "%s" | ||
| } | ||
| resource "azurerm_servicebus_namespace" "test" { |
There was a problem hiding this comment.
And add a space here between the resources
|
@katbyte Thanks for review, updated. |
|
Tests pass:
|
tombuildsstuff
changed the title
tombuildsstuff
changed the title
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Deleting service bus in tanscation that resource group deletion will be blocked when sku set to premium.
Added WaitForCompletionRef method to make sure service bus was deleted and also added test for premium sku.
Thanks,
Chang