Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb_rule: allow 0 for ports again #1951

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Sep 19, 2018

allows the workaround described in #372 to work again

@katbyte katbyte added this to the 1.16.0 milestone Sep 19, 2018
@katbyte katbyte requested a review from a team September 19, 2018 22:06
@ghost ghost added the size/XS label Sep 19, 2018
@katbyte katbyte force-pushed the b-lb_rule-portvalidation branch from cb0bdf1 to 1e19d80 Compare September 19, 2018 22:07
@ghost ghost added size/M and removed size/XS labels Sep 19, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit 6d22044 into master Sep 19, 2018
katbyte added a commit that referenced this pull request Sep 19, 2018
@tombuildsstuff tombuildsstuff deleted the b-lb_rule-portvalidation branch September 19, 2018 23:46
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants