App Service Custom Hostname Binding: support for multiple bindings #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change:
```
$ ARM_TEST_APP_SERVICE=tomdevacctest12345 ARM_TEST_DOMAIN=REDACTED ARM_ALT_TEST_DOMAIN=REDACTED acctests azurerm TestAccAzureRMAppServiceCustomHostnameBinding
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic/basic
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding/basic/import
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding (299.70s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic (299.70s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic/basic (135.97s)
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding/basic/import (163.72s)
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding_multiple
--- FAIL: TestAccAzureRMAppServiceCustomHostnameBinding_multiple (112.01s)
testing.go:573: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Error applying: 1 error(s) occurred:
* azurerm_app_service_custom_hostname_binding.test2 (destroy): 1 error(s) occurred:
* azurerm_app_service_custom_hostname_binding.test2: web.AppsClient#DeleteHostNameBinding: Failure sending request: StatusCode=409 -- Original Error: autorest/azure: Service returned an error. Status=<nil> <nil>
```
after this change:
```
$ ARM_TEST_APP_SERVICE=tomdevacctest12345 ARM_TEST_DOMAIN=REDACTED ARM_ALT_TEST_DOMAIN=REDACTED acctests azurerm TestAccAzureRMAppServiceCustomHostnameBinding_multiple
=== RUN TestAccAzureRMAppServiceCustomHostnameBinding_multiple
--- PASS: TestAccAzureRMAppServiceCustomHostnameBinding_multiple (157.72s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 158.148s
```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure API only allows a single hostname to be added/removed at once. This PR adds a lock to ensure this is the case
before this change:
after this change:
Fixes #1968