-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW RESOURCE] SQL ElasticPool using 2017-10-01-preview API #2071
Conversation
@jeffreyCline Please fix the building error, add test case and doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeffreyCline,
Thanks for renaming the resource. In addition to the comments i've left inline the documentation is missing the import section.
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
…/terraform-providers/terraform-provider-azurerm into u-elasticPool-2017-10-01-preview
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
Co-Authored-By: jeffreyCline <jcline@microsoft.com>
b4f4ff2
to
900b6a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 👍
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
(fixes #1605)
(fixes #1745)
(fixes #1931)