Refactoring: Resource Provider Registration / Auth prep. #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ acctests azurerm TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered === RUN TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered --- PASS: TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered (6.53s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 8.404s ```
Tests pass: ``` $ acctests azurerm TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered === RUN TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered --- PASS: TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered (5.90s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 7.278s ```
bflad
approved these changes
Oct 31, 2018
|
Resource Provider Registration test passes: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Resource Provider registration out into it's own package; it also moves some of the Authentication related stuff out into it's own package since it's going to be refactored further in the near future.
As a part of refactoring the Resource Provider registration out, I've also inverted the dependency such that we're able to reuse the RP Registration once it's pulled out it's own library - which will become part of the greater shared authentication library (across AzureRM/Public, Azure Stack and the AzureRM Backend in Terraform Core)
In the near future the intention is to have a shared authentication package with feature toggles for AzureCLIParsingAuth, ClientSecretAuth, CloudShellAuth etc - so that we're able to decide what's supported in each location as necessary (for example, CloudShell isn't available in Azure Stack); so whilst some of this PR may seem superfluous, there's some prep work for the upcoming refactor