Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: using the split-out auth package #2355

Merged
merged 7 commits into from
Nov 20, 2018
Merged

Refactor: using the split-out auth package #2355

merged 7 commits into from
Nov 20, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Switching over to using the new github.com/hashicorp/go-azure-helpers package now that it's split out

Once this is merged I'll send a follow up to update existing calls to the (now) deprecated package in ./azurerm/helpers/response

@tombuildsstuff tombuildsstuff added this to the 1.20.0 milestone Nov 19, 2018
@ghost ghost added the size/XXL label Nov 19, 2018
katbyte
katbyte approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖🚀

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

$ acctests azurerm TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered
=== RUN   TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered
...
--- PASS: TestAccAzureRMEnsureRequiredResourceProvidersAreRegistered (6.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	7.910s

@tombuildsstuff tombuildsstuff merged commit cc14eca into master Nov 20, 2018
@tombuildsstuff tombuildsstuff deleted the f/refactor-auth branch November 20, 2018 09:58
tombuildsstuff added a commit that referenced this pull request Nov 20, 2018
@tombuildsstuff
Updating to include #2355
9cf5770
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
authentication refactor size/XXL
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte