Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authentication: requesting a token using the audience address #2381

Merged
merged 1 commit into from
Nov 26, 2018
Merged

authentication: requesting a token using the audience address #2381

merged 1 commit into from
Nov 26, 2018

Conversation

tombuildsstuff
Copy link
Contributor

This brings the AzureRM Provider into line with Azure Stack:

$ acctests azurerm TestAccAzureRMResourceGroup_basic
=== RUN   TestAccAzureRMResourceGroup_basic
=== PAUSE TestAccAzureRMResourceGroup_basic
=== CONT  TestAccAzureRMResourceGroup_basic
--- PASS: TestAccAzureRMResourceGroup_basic (77.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	79.288s

@ghost ghost added the size/XS label Nov 26, 2018
@tombuildsstuff tombuildsstuff requested a review from a team November 26, 2018 09:35
katbyte
katbyte approved these changes Nov 26, 2018
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit da1f699 into master Nov 26, 2018
@tombuildsstuff tombuildsstuff deleted the r/auth-endpoint branch November 26, 2018 19:40
tombuildsstuff added a commit that referenced this pull request Nov 26, 2018
@tombuildsstuff
Updating to include #2381
933348f
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
authentication enhancement size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @katbyte