-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/kubernetes_cluster: support for rbac without azuread / exporting the admin profile #2495
Conversation
Resource Tests pass for this (excluding the version of K8s used in the test being unavailable, which I've pushed a commit to fix: Data Source tests pass, excluding a known test failure which we'll look at separately: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -169,6 +169,8 @@ A `role_based_access_control` block supports the following: | |||
|
|||
* `azure_active_directory` - (Required) An `azure_active_directory` block. Changing this forces a new resource to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required? Or can be skipped if one wants just RBAC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot - this is now optional
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR adds support for Role Based Access Control without Azure Active Directory to both the
azurerm_kubernetes_cluster
Resource and Data Source; and also exports the Kubernetes Admin Profile if Role Based Access Control with AzureAD is enabled on the cluster to both the Resource & Data Source too.Fixes #2345
Fixes #2421
Supersedes #2347