Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_api_management_property #2986

Merged
merged 7 commits into from
Mar 4, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Mar 1, 2019

This PR adds azurerm_api_management_property to the provider.

=== RUN   TestAccAzureRMAPIManagementProperty_basic
=== PAUSE TestAccAzureRMAPIManagementProperty_basic
=== RUN   TestAccAzureRMAPIManagementProperty_update
=== PAUSE TestAccAzureRMAPIManagementProperty_update
=== CONT  TestAccAzureRMAPIManagementProperty_basic
=== CONT  TestAccAzureRMAPIManagementProperty_update
--- PASS: TestAccAzureRMAPIManagementProperty_basic (1603.38s)
--- PASS: TestAccAzureRMAPIManagementProperty_update (1992.85s)

@mbfrahry mbfrahry requested a review from a team March 1, 2019 21:15
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mbfrahry,

Commented on a couple minor mistakes I think need fixing, but other then that LGTM

azurerm/resource_arm_api_management_property.go Outdated Show resolved Hide resolved
website/azurerm.erb Outdated Show resolved Hide resolved
website/azurerm.erb Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment in addition to @katbyte's but this otherwise LGTM 👍


* `value` - (Required) The value of this API Management Property.

* `secret` - (Optional) Specifies whether the API Management Property is secret. Valid values are `true` or `false`. The default value is `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it could be worth a yellow info box here explaining this isn't making it sensitive within Terraform e.g.

~> **NOTE:** setting the field `secret` to `true` doesn't make this field sensitive in Terraform, instead it ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@tombuildsstuff tombuildsstuff merged commit d9a4342 into master Mar 4, 2019
@tombuildsstuff tombuildsstuff deleted the f-api-management-property branch March 4, 2019 16:47
tombuildsstuff added a commit that referenced this pull request Mar 4, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants