Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_certificate #3141

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds support for API Management Certificates, a part of #1177

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-03-28 at 23 24 57

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple minor comments 👍

katbyte and others added 2 commits March 29, 2019 07:14
Co-Authored-By: tombuildsstuff <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: tombuildsstuff <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff tombuildsstuff merged commit dc5976e into master Mar 29, 2019
@tombuildsstuff tombuildsstuff deleted the f/api-management-certificates branch March 29, 2019 06:31
tombuildsstuff added a commit that referenced this pull request Mar 29, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants