Role Assignment - Treat name as case insensitive

[kiall]

When the wrong case is used for a role name, e.g. acrpull instead of the
correct AcrPull, azure will accept the request and return the correct
casing. This results in Terraform believing it needs to update the
resource incorrectly.

Example of incorrect behaviour:

-/+ module.aks_simple.module.acr.azurerm_role_assignment.acr_spn_pull_role_assn (new resource required)
      role_definition_name:      "AcrPull" => "acrpull" (forces new resource)

[tombuildsstuff]

hi @kiall

Thanks for opening this PR :)

Case Sensitivity's an interesting problem in Azure (and Terraform) - whilst certain parts of Azure (and the API Specifications) define certain fields (e.g. Resource ID's) as case insensitive - other API's which use that information sometimes require that they're cased correctly.

For this reason whilst historically we've opted to treat some fields as case insensitive - on the whole we're moving towards making the provider case sensitive. As an example, this means that any new fields we add are case-sensitive for both the field value and the validation (which works around these bugs, and also matches the behaviour of other Terraform providers).

That said - in this instance since this field is only used for searching for the role name to obtain it's ID, rather than to be used as a value passed into another service, I think this makes sense (and is a nice UX improvement) - so thanks for this PR 👍🏻

Thanks!

[tombuildsstuff]

LGTM - thanks for this 👍

[ghost]

This has been released in version 1.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!