[azurerm_storage_account] support for the enable_advanced_threat_protection property

[benjamin37]

I'm not sure about the following point of this pull request. Advanced Threat Protection is a feature you can set on a storage account. However it is set with a separate client AdvancedThreatProtectionClient and not with the StorageServiceClient. Is it common practice to create a new resource for this setting instead of adding it to the storage account itself?

Relates to issue #3670

(fixes #3670)

[katbyte]

Hi @benjamin37,

Thank you for the PR! Overall this is looking really great with a few fairly minor comments i've left inline. Once those are addressed this should be good to merge 🙂

(also this is perfect, and mimics the SQL one mentioned in the issue)

[benjamin37]

Hi @katbyte,

thanks for the fast reply and your feedback! I've commited the changes you requested. Just let me know if there is anything else to do for this pull request.

Kind regards

[katbyte]

Thanks for the revisions @benjamin37, this LGTM now 🙂

[ghost]

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!