Bump Azure SDK to v33.2.0 #4334
Conversation
evenh
force-pushed
the
bump-azure-sdk
branch
from
2e26ec5 to
3962116
Compare
There was a problem hiding this comment.
hey @evenh
Thanks for this PR - taking a look through this LGTM; I hope you don't mind but so that we can get this merged I'm going to push a commit to switch over the validation function to use the new constants (since there's been an open todo for this, which we'll do now they're available) - but this otherwise LGTM 👍
Thanks!
| @@ -259,7 +259,7 @@ func expandKustoClusterSku(d *schema.ResourceData) (*kusto.AzureSku, error) { | |||
|
|
|||
| azureSku := &kusto.AzureSku{ | |||
| Name: kusto.AzureSkuName(name), | |||
| Tier: &tier, | |||
| Tier: kusto.AzureSkuTier(tier), | |||
There was a problem hiding this comment.
since there's now a type for this could we switch the validation function (above) to using those constants? will do this in a subsequent PR
|
Travis is failing because this isn't rebased on the latest master, but this otherwise seems fine 👍 |
|
Thanks for the quick merge :-) |
|
This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.35.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Enables development of #4322