-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: data_factory_integration_runtime_managed #4342
New Resource: data_factory_integration_runtime_managed #4342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r0bnet. These changes look great! There are some missed errors and checks that we should do and I've called those out below.
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
azurerm/resource_arm_data_factory_integration_runtime_managed.go
Outdated
Show resolved
Hide resolved
website/docs/r/data_factory_integration_runtime_managed.html.markdown
Outdated
Show resolved
Hide resolved
Fixed most of the stuff except two things: no import steps for catalog info and custom setup script tests as password or sas token is not returned via API so it differs from what is in the state. |
You can throw in an ImportStateVerifyIgnore to ignore the fields that aren't returned from the API (i.e. |
Ah okay. Thanks. Fixed that for the two tests and it ran the tests locally. Seems to be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up @r0bnet. Apologies for the rebasing you had to do
@r0bnet , I am looking for terraform code to create "Datafactory Azure-SSIS Integration runtime" , could you please help, where to get it. |
Hey @muralidar44, sure. Looking at the documentation there is already an up&running example. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Requested and discussed here: #3275