Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tackling various vmss issues #448

Merged
merged 3 commits into from
Oct 21, 2017
Merged

Tackling various vmss issues #448

merged 3 commits into from
Oct 21, 2017

Conversation

mbfrahry
Copy link
Member

This PR adds the new sdk features to virtual machine scale sets and fixes #160, #339, and #340

=== RUN   TestAccAzureRMVirtualMachineScaleSet_basicPublicIP
--- PASS: TestAccAzureRMVirtualMachineScaleSet_basicPublicIP (402.10s)
=== RUN   TestAccAzureRMVirtualMachineScaleSet_bootDiagnostic
--- PASS: TestAccAzureRMVirtualMachineScaleSet_bootDiagnostic (400.54s)
=== RUN   TestAccAzureRMVirtualMachineScaleSet_networkSecurityGroup
--- PASS: TestAccAzureRMVirtualMachineScaleSet_networkSecurityGroup (400.65s)
=== RUN   TestAccAzureRMVirtualMachineScaleSet_basicAcceleratedNetworking
--- PASS: TestAccAzureRMVirtualMachineScaleSet_basicAcceleratedNetworking (339.38s)

@mbfrahry mbfrahry requested a review from vancluever October 20, 2017 22:08
vancluever
vancluever approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@vancluever vancluever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One single comment but otherwise LGTM!

azurerm/resource_arm_virtual_machine_scale_set.go Outdated
"accelerated_networking": {
Type: schema.TypeBool,
Optional: true,
Default: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe omit zero value here?

@mbfrahry mbfrahry merged commit 427896f into master Oct 21, 2017
@mbfrahry mbfrahry deleted the p-vmss branch October 21, 2017 01:09
@tombuildsstuff tombuildsstuff mentioned this pull request Apr 17, 2018
Closed
@katbyte katbyte mentioned this pull request May 10, 2018
Closed
@tombuildsstuff tombuildsstuff mentioned this pull request May 10, 2018
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vancluever vancluever vancluever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMSS: support for specifying the OS Disk Size
2 participants
@mbfrahry @vancluever