Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_automation_account #4740

Merged
merged 7 commits into from
Oct 29, 2019
Merged

New Data Source: azurerm_automation_account #4740

merged 7 commits into from
Oct 29, 2019

Conversation

whytoe
Copy link
Contributor

@whytoe whytoe commented Oct 28, 2019

This Data provider exposes the Keys property in Azure Portal for Automation Account, it uses the goSDK function ".Automation.AgentRegistrationInfoClient" in the ARM client.

I wouldnt be opposed to renaming the data source to be more descriptive but I thought it might be a good idea to expand on this data source for all the automation account properties instead of maintaining multiple data providers for the same resource.

Woytowich, Dan (MTO) added 2 commits October 28, 2019 10:47
@ghost ghost added size/L and removed size/XL labels Oct 29, 2019
Woytowich, Dan (MTO) added 3 commits October 29, 2019 00:55
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @whytoe, this mostly looks good but azurerm.erb had some extra removals and white space additions that should be addressed.

website/azurerm.erb Outdated Show resolved Hide resolved
website/azurerm.erb Outdated Show resolved Hide resolved
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Data Source azurerm_automation_account - exposes "Keys" and Endpoint configuration New Data Source: azurerm_automation_account Oct 29, 2019
@mbfrahry mbfrahry merged commit a31671c into hashicorp:master Oct 29, 2019
@whytoe
Copy link
Contributor Author

whytoe commented Oct 30, 2019

hey @mbfrahry should this be included in the milestones so it makes it into the changelog? i believe it resolved #2162 as well

@mbfrahry mbfrahry added this to the v1.37.0 milestone Oct 30, 2019
@mbfrahry
Copy link
Member

Good call @whytoe. It looks like this does close that issue as well. Thanks!

@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants