Rename iot_dps resources to iothub_dps and add missing properties
#4896
Conversation
- Fixes hashicorp#4879 - Adds following properties as outputs: - service_operation_host_name - device_provisioning_host_name - id_scope - allocation_policy
katbyte
changed the title
iot_dps resources to iothub_dps and add missing properties
There was a problem hiding this comment.
Thank you so much for renaming these @Brunhil! one less thing i have to do for 2.0 😃
However we do typically keep the old resources around so there are no breaking changes, as such could we just copy the old files back in, mark them as deprecated & add that they will be removed in 2.0 to the upgrade guide?
Other then that and 2 minor comments this looks good to go!
-kt
=== RUN TestAccAzureRMIotDPS_basic --- PASS: TestAccAzureRMIotDPS_basic (170.14s)
- Rename internal resources to match the correct resource (arm_iot vs arm_iothub)
- Add changes to 2.0 upgrade guide
- Add removal of iot_dps_* resources
- Combine some resources that were already listed in the guide
- Restructure renamed resources guide for these changes
| @@ -9,20 +9,17 @@ description: |- | |||
|
|
|||
There was a problem hiding this comment.
I went a head and made changes here to support future versions. Let me know your thoughts @katbyte
|
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Abandoned PR 4881 as I had rebased from master and messed up history. This pulls in only the changes from that branch :).