New Resource: azurerm_mssql_virtual_machine

[yupwei68]

add resource mssqlvm

fixes #3891

fixes Azure/terraform-azurerm-compute#63

2020.03.05 all test passed!

[katbyte]

Hi @yupwei68, thank you for the new resource,

I've done an initial review and left comments inline that need to be addressed.

[tombuildsstuff]

hi @yupwei68

Thanks for pushing those changes/rebasing this - I've taken a look through and left some comments in addition to the ones @katbyte's left - primarily around the schema design, but this is off to a good start; if we can fix those up then we should be able to take another look 👍

Thanks!

[yupwei68]

hi @tombuildsstuff @katbyte ,I have updated code and restested with pass to fit azurerm 2.0. Please help to review.

[katbyte]

Thanks @yupwei68,

I've left some more comments inline that should be addressed before merge.

[katbyte]

Thanks for the change @yupwei68, just a couple more minor comments and it seems like the tests are failing in our CI:

Test Failed

------- Stdout: -------
=== RUN   TestAccAzureRMMsSqlVirtualMachine_basic
=== PAUSE TestAccAzureRMMsSqlVirtualMachine_basic
=== CONT  TestAccAzureRMMsSqlVirtualMachine_basic
--- FAIL: TestAccAzureRMMsSqlVirtualMachine_basic (150.75s)
    testing.go:640: Step 0 error: errors during apply:
        
        Error: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="SkuNotAvailable" Message="The requested size for resource '/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-mssql-200325213822100701/providers/Microsoft.Compute/virtualMachines/acctest-VM-200325213822100701' is currently not available in location 'westeurope' zones '' for subscription '1a6092a6-137e-4025-9a7c-ef77f76f2c02'. Please try another size or deploy to a different location or zones. See https://aka.ms/azureskunotavailable for details."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test082828343/main.tf line 90:
          (source code not available)

[jackofallops]

Hi @yupwei68
Just adding to Kt's comment above on the test. It looks like the SKU in the test isn't available in our primary test location. Could you update the test to use a newer VM Resource that's supported in westeurope? (Suggest Standard_F2s?)

[Ugo-G]

Salut @ yupwei68 Ajout
juste au commentaire de Kt ci-dessus sur le test. Il semble que la référence du test ne soit pas disponible dans notre emplacement de test principal. Pourriez-vous mettre à jour le test pour utiliser une nouvelle ressource VM prise en charge dans westeurope? (Suggérer Standard_F2s?)

Hello,
Please note, I do not know if this subject is related to this problem, but most Azure servers are currently full in Europe.
Servers in France, the United Kingdom and Northern Europe are affected.
There is still a little space in Western Europe, but it is still unstable.

[jackofallops]

Hello,
Please note, I do not know if this subject is related to this problem, but most Azure servers are currently full in Europe.
Servers in France, the United Kingdom and Northern Europe are affected.
There is still a little space in Western Europe, but it is still unstable.

Thanks @Ugo-G - we've seen evidence of this also. The test didn't need the size of instance it was using to check the functionality. I'm also reasonably sure that the SKU in the test isn't normally available in West Europe in normal conditions (though v2 variants are).

[yupwei68]

@katbyte @jackofallops Sorry the delay. I have updated the comments' changes. But recently, the update autopatch functions seem to fail in service team. They're looking for solution.

[katbyte]

Thanks for the changes @yupwei68, LGTM now 👍

[azjon]

Hi,

Are there any plans to add support for spanned disks, I'm currently trying to add multiple disks for data, log, tempdb. In ARM this is configured in the SQL extension or SQL resource provider:

"StorageConfigurationSettings": {
"DiskConfigurationType": "NEW",
"StorageWorkloadType": "OLTP",
"SQLDataSettings": {
"LUNs": "[1,2]",
"DefaultFilePath": "S:\ExamplePath\Data"
},
"SQLLogSettings": {
"LUNs": "[3,4]",
"DefaultFilePath": "F:\ExamplePath\Data"
},
"SQLTempDbSettings": {
"LUNs": "[5,6]",
"DefaultFilePath": "G:\ExamplePath\TempDB"
}
}

[yupwei68]

Hi @azjon , we shall wait till the service returns the storage configuration back.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!