New Resource: azurerm_express_route_gateway

[brent-au]

This PR adds the new ExpressRoute Gateway resource which can be deployed into Virtual Hub networks.

[katbyte]

Thanks for the new resource @brent-au! overall this looks good, i've left some mostly minor comment inline to address

[brent-au]

Thanks for the feedback @katbyte , have submitted a new commit that should resolve majority of the issues raised.

[tombuildsstuff]

hey @brent-au

Thanks for pushing those changes - apologies for the delayed re-review here!

I've left a few comments inline but this otherwise LGTM - if we can fix those up (and the tests pass) then this otherwise looks good to me 👍

Thanks!

dismissing since changes have been pushed

[tombuildsstuff]

hey @brent-au

Thanks for pushing those changes / apologies for the delayed re-review here!

I've taken another look through and left a few minor comments but this otherwise LGTM - since this otherwise looks good I hope you don't mind but I'm going to push a commit to resolve the PR comments so that we can kick off the tests and get this merged 👍

Thanks!

dismissing since the API behaviour has changed from what exists in the SDK 🙃

[tombuildsstuff]

LGTM - thanks for this @brent-au

[tombuildsstuff]

Running the tests picked up a couple of minor issues (which, whilst we'd normally fix in this PR prior to merging I'm going to open a separate PR to fix, since Travis seems to be having delays with PR builds right now & they're fairly minor things to fix)

[tombuildsstuff]

Suggested change

	scale_unts = 1
	scale_units = 1

[tombuildsstuff]

Suggested change

	location = azurerm_express_route_gateway.test.location
	location = azurerm_express_route_gateway.test.location
	virtual_hub_id = azurerm_express_route_gateway.test.virtual_hub_id

[ghost]

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!