New Resource: `azurerm_hpc_cache` #5528

aqche · 2020-01-26T21:23:25Z

Adds the azurerm_hpc_cache resource.

…form-provider-azurerm into azurerm_hpc_cache

…, tag formmating, docs updates

…form-provider-azurerm into azurerm_hpc_cache

aqche · 2020-01-31T02:52:23Z

PR should be ready for review now.

One note is I didn't add support for tags b/c I was running into a strange issue where client.Get always returned the tags that the cache was initially created with despite if they changed. (For example. I deployed a HPC Cache with a label:test tag. And although I was able to update the tags withclient.CreateOrUpdate to label:test1 and see the changes in the portal, client.Get still returned label:test.)

aqche · 2020-01-31T02:53:23Z

Tests Pass:

=== RUN   TestAccAzureRMHPCCache_basic
=== PAUSE TestAccAzureRMHPCCache_basic
=== CONT  TestAccAzureRMHPCCache_basic
--- PASS: TestAccAzureRMHPCCache_basic (1609.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storagecache/tests  1609.518s

…form-provider-azurerm into azurerm_hpc_cache

tombuildsstuff

hey @aqche

Thanks for this PR - apologies for the delayed review here!

I've taken a look through and left some comments inline, but this is mostly looking good to me - I'll send a request to opt us into the HPC Cache RP now too 👍

Thanks!

website/allowed-subcategories

website/docs/r/hpc_cache.html.markdown

tombuildsstuff · 2020-02-10T07:02:40Z

website/docs/r/hpc_cache.html.markdown

+HPC Cache can be imported using the `resource id`, e.g.
+
+```shell
+terraform import azurerm_hpc_cache.example /subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroupName/providers/Microsoft.StorageCache/caches/cacheName


since this is a new Resource Provider (Microsoft.StorageCache) could we add that to this list

website/docs/r/hpc_cache.html.markdown

tombuildsstuff · 2020-02-10T07:04:32Z

website/azurerm.erb

@@ -2224,6 +2224,15 @@
              </ul>
            </li>

+            <li>
+              <a href="#">Storage Cache Resources</a>


rather than making this it's own group could we move this into the Storage list?

tombuildsstuff · 2020-02-10T07:04:57Z

azurerm/internal/services/storagecache/registration.go

+// SupportedResources returns the supported Resources supported by this Service
+func (r Registration) SupportedResources() map[string]*schema.Resource {
+	return map[string]*schema.Resource{
+		"azurerm_hpc_cache": resourceArmHPCCache(),


rather than making this it's own service could we move this into the Storage service, since it forms part of that?

tombuildsstuff · 2020-02-10T07:05:02Z

azurerm/internal/services/storagecache/client/client.go

+
+	return &Client{
+		CachesClient: &cachesClient,
+	}


rather than making this it's own service could we move this into the Storage service, since it forms part of that?

Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>

…form-provider-azurerm into azurerm_hpc_cache

…er-azurerm into azurerm_hpc_cache

aqche · 2020-02-11T05:19:05Z

Looks like website-lint is failing to something unrelated to these PR changes.

edit: fixed after merging master in

…form-provider-azurerm into azurerm_hpc_cache

WodansSon

@aqche , Thanks for the PR and pushing the updates... This LGTM now! 🚀

magodo · 2020-02-28T03:49:31Z

azurerm/internal/services/storage/resource_arm_hpc_cache.go

+		return fmt.Errorf("Error creating HPC Cache %q (Resource Group %q): %+v", name, resourceGroup, err)
+	}
+
+	stateConf := &resource.StateChangeConf{


@aqche
I may be dumb here, why not just use future.WaitForCompletionRef() here? Is there some limitation about this API?

@magodo thanks for calling that out, it actually slipped my mind to try future.WaitForCompletionRef() here first. I'll give it a test and report back.

update: worked like a charm!

…form-provider-azurerm into azurerm_hpc_cache

aqche · 2020-02-28T06:01:15Z

@tombuildsstuff @WodansSon made a small update to use future.WaitForCompletionRef() as suggested by @magodo. Feel free to review the PR again whenever ya'll have time!

=== RUN   TestAccAzureRMHPCCache_basic
=== PAUSE TestAccAzureRMHPCCache_basic
=== CONT  TestAccAzureRMHPCCache_basic
--- PASS: TestAccAzureRMHPCCache_basic (1701.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       1701.700s

katbyte

Thanks for the revisions @aqche, have left some additional mostly minor comments that once addressed this should be good to merge

katbyte · 2020-02-28T21:37:06Z

azurerm/internal/services/storage/resource_arm_hpc_cache.go

+	id, err := azure.ParseAzureResourceID(d.Id())
+	if err != nil {
+		return err
+	}
+	resourceGroup := id.ResourceGroup
+	name := id.Path["caches"]


We are starting to write Parse ID functions for all resources, you can see an example here: #5779

azurerm/internal/services/storage/resource_arm_hpc_cache.go

azurerm/internal/services/storage/tests/resource_arm_hpc_cache_test.go

katbyte · 2020-02-28T21:42:19Z

website/docs/r/hpc_cache.html.markdown

+
+Manages a HPC Cache.
+
+~> **Note**: During the first several months of the GA release, a request must be made to the Azure HPC Cache team to add your subscription to the access list before it can be used to create a cache instance.


Could we add a link to where a user could do that?

katbyte · 2020-02-28T21:42:34Z

website/docs/r/hpc_cache.html.markdown

+  location            = "${azurerm_resource_group.example.location}"
+  resource_group_name = "${azurerm_resource_group.example.name}"


Could we use .12 syntax for the docs?

website/docs/r/hpc_cache.html.markdown

Co-Authored-By: kt <kt@katbyte.me>

aqche · 2020-02-29T20:54:44Z

@katbyte, thanks for the review! make the updates you suggested 👍

Resource Test:

=== RUN   TestAccAzureRMHPCCache_basic
=== PAUSE TestAccAzureRMHPCCache_basic
=== CONT  TestAccAzureRMHPCCache_basic
--- PASS: TestAccAzureRMHPCCache_basic (1439.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/storage/tests       1439.417s

Parser Test:

go test hpc_cache.go hpc_cache_test.go
ok      command-line-arguments  0.009s

katbyte

Thanks for the revisions @aqche, LGTM aside from one missed comment, as per toms request we need to add this to the list of required resource providers. once that is done this is good to merge

aqche · 2020-03-02T23:25:03Z

azurerm/internal/provider/required_resource_providers.go

@@ -62,6 +62,7 @@ func RequiredResourceProviders() map[string]struct{} {
 		"Microsoft.ServiceFabric":        {},
 		"Microsoft.Sql":                  {},
 		"Microsoft.Storage":              {},
+		"Microsoft.StorageCache":         {},


@katbyte i've updated the RequiredResourceProviders func here. let me know if this is correct. thanks!

aqche · 2020-03-02T23:26:46Z

@katbyte thanks for reviewing the PR again! added a review comment addressing your last request. (just commenting so the waiting-response tag gets removed)

katbyte

Thanks @aqche! LGTM, now just waiting on approval from the HPC team so we can test this.

outdated

ghost · 2020-03-11T21:36:40Z

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

ghost · 2020-04-05T14:50:01Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

wip: add azurerm_hpc_cache resource

efe8b6e

ghost added the size/XL label Jan 26, 2020

run go mod vendor

a9c830b

ghost added dependencies size/XXL and removed size/XL labels Jan 26, 2020

aqche added 3 commits January 26, 2020 20:41

formatting fixes for resource_arm_hpc_cache_test.go

75004c2

more resource_arm_hpc_cache_test.go formatting

036dbea

wip: create docs for azurerm_hpc_cache

a58691f

ghost added the documentation label Jan 27, 2020

aqche added 7 commits January 27, 2020 00:02

add Storage Cache to allowed-subcategories

cd0d8cd

Merge branch 'master' of https://github.com/terraform-providers/terra…

98559fb

…form-provider-azurerm into azurerm_hpc_cache

hpc cache: cache size valudation, sku name arg, wait for provisioning…

e283c73

…, tag formmating, docs updates

whitespace

b765f66

whitespace

205492c

remove tags

d795f90

Merge branch 'master' of https://github.com/terraform-providers/terra…

e77d488

…form-provider-azurerm into azurerm_hpc_cache

aqche changed the title ~~[WIP] New Resource: azurerm_hpc_cache~~ New Resource: azurerm_hpc_cache Jan 31, 2020

aqche marked this pull request as ready for review January 31, 2020 02:46

Merge branch 'master' of https://github.com/terraform-providers/terra…

c32a6e3

…form-provider-azurerm into azurerm_hpc_cache

tombuildsstuff added new-resource service/storage labels Feb 10, 2020

tombuildsstuff previously requested changes Feb 10, 2020

View reviewed changes

tombuildsstuff added the waiting-response label Feb 10, 2020

aqche and others added 4 commits February 10, 2020 19:40

Apply suggestions from code review

6edea9f

Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Merge branch 'master' of https://github.com/terraform-providers/terra…

c6df54b

…form-provider-azurerm into azurerm_hpc_cache

Merge branch 'azurerm_hpc_cache' of github.com:aqche/terraform-provid…

22b634b

…er-azurerm into azurerm_hpc_cache

apply review suggestions

7bbbaba

aqche and others added 3 commits February 11, 2020 15:25

Merge branch 'master' of https://github.com/terraform-providers/terra…

5035ba1

…form-provider-azurerm into azurerm_hpc_cache

merge conflicts

324f369

Merge branch 'master' into azurerm_hpc_cache

5c7f4cb

WodansSon approved these changes Feb 28, 2020

View reviewed changes

magodo reviewed Feb 28, 2020

View reviewed changes

aqche added 2 commits February 27, 2020 20:48

Merge branch 'master' of https://github.com/terraform-providers/terra…

df8d3a6

…form-provider-azurerm into azurerm_hpc_cache

use future.WaitForCompletionRef() for hpc creation

19cce38

katbyte requested changes Feb 28, 2020

View reviewed changes

katbyte added the waiting-response label Feb 28, 2020

aqche and others added 3 commits February 29, 2020 10:56

Apply suggestions from code review

75547ea

Co-Authored-By: kt <kt@katbyte.me>

address review

35a5a6b

fmt

a7f9030

ghost removed the waiting-response label Feb 29, 2020

katbyte requested changes Mar 2, 2020

View reviewed changes

katbyte added the waiting-response label Mar 2, 2020

aqche commented Mar 2, 2020

View reviewed changes

ghost removed the waiting-response label Mar 2, 2020

katbyte approved these changes Mar 5, 2020

View reviewed changes

katbyte added this to the v2.1.0 milestone Mar 5, 2020

katbyte merged commit 4858607 into hashicorp:master Mar 5, 2020

katbyte added a commit that referenced this pull request Mar 5, 2020

Update CHANGELOG.md to include #5528

3401e09

aqche deleted the azurerm_hpc_cache branch March 6, 2020 00:00

ghost locked and limited conversation to collaborators Apr 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_hpc_cache` #5528

New Resource: `azurerm_hpc_cache` #5528

aqche commented Jan 26, 2020

aqche commented Jan 31, 2020 •

edited

Loading

aqche commented Jan 31, 2020

tombuildsstuff left a comment

tombuildsstuff Feb 10, 2020

tombuildsstuff Feb 10, 2020

tombuildsstuff Feb 10, 2020

tombuildsstuff Feb 10, 2020

aqche commented Feb 11, 2020 •

edited

Loading

WodansSon left a comment

magodo Feb 28, 2020 •

edited

Loading

aqche Feb 28, 2020 •

edited

Loading

aqche commented Feb 28, 2020

katbyte left a comment

katbyte Feb 28, 2020

katbyte Feb 28, 2020

katbyte Feb 28, 2020

aqche commented Feb 29, 2020

katbyte left a comment

aqche Mar 2, 2020

aqche commented Mar 2, 2020

katbyte left a comment

ghost commented Mar 11, 2020

ghost commented Apr 5, 2020


		Manages a HPC Cache.

		~> Note: During the first several months of the GA release, a request must be made to the Azure HPC Cache team to add your subscription to the access list before it can be used to create a cache instance.

		location = "${azurerm_resource_group.example.location}"
		resource_group_name = "${azurerm_resource_group.example.name}"

New Resource: azurerm_hpc_cache #5528

New Resource: azurerm_hpc_cache #5528

Conversation

aqche commented Jan 26, 2020

aqche commented Jan 31, 2020 • edited Loading

aqche commented Jan 31, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aqche commented Feb 11, 2020 • edited Loading

WodansSon left a comment

Choose a reason for hiding this comment

magodo Feb 28, 2020 • edited Loading

Choose a reason for hiding this comment

aqche Feb 28, 2020 • edited Loading

Choose a reason for hiding this comment

aqche commented Feb 28, 2020

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aqche commented Feb 29, 2020

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aqche commented Mar 2, 2020

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Mar 11, 2020

ghost commented Apr 5, 2020

New Resource: `azurerm_hpc_cache` #5528

New Resource: `azurerm_hpc_cache` #5528

aqche commented Jan 31, 2020 •

edited

Loading

aqche commented Feb 11, 2020 •

edited

Loading

magodo Feb 28, 2020 •

edited

Loading

aqche Feb 28, 2020 •

edited

Loading