Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_database - support for zone_redundant #5772

Merged
merged 4 commits into from
Feb 19, 2020
Merged

azurerm_sql_database - support for zone_redundant #5772

merged 4 commits into from
Feb 19, 2020

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Feb 15, 2020

Fixes #5672

Adds the zone_redundant option to the azurerm_sql_database resource.

=== RUN   TestAccAzureRMSqlDatabase_zoneRedundant
=== PAUSE TestAccAzureRMSqlDatabase_zoneRedundant
=== CONT  TestAccAzureRMSqlDatabase_zoneRedundant
--- PASS: TestAccAzureRMSqlDatabase_zoneRedundant (368.49s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sql/tests   368.513s

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @aqche

Thanks for this PR :)

I've taken a look through and left some minor comments inline but this otherwise LGTM 👍

Thanks!

aqche and others added 3 commits February 18, 2020 16:25
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@aqche
Copy link
Contributor Author

aqche commented Feb 19, 2020

@tombuildsstuff thanks for the review! made the updates you suggested.

--- PASS: TestAccAzureRMSqlDatabase_zoneRedundant (807.74s)

@ghost ghost removed the waiting-response label Feb 19, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests look fine 👍

@tombuildsstuff tombuildsstuff merged commit 7e03bc6 into hashicorp:master Feb 19, 2020
tombuildsstuff added a commit that referenced this pull request Feb 19, 2020
@aqche aqche deleted the azurerm_sql_database_zone_redundant branch February 20, 2020 09:57
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for zoneRedundant property of azurerm_sql_database through terraform
2 participants