Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/two-oh-todo-automation #5781

Merged
merged 8 commits into from
Feb 18, 2020
Merged

F/two-oh-todo-automation #5781

merged 8 commits into from
Feb 18, 2020

Conversation

jackofallops
Copy link
Member

found some more 2.0 changes

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from updating the tests to account for this this otherwise LGTM 👍

@ghost ghost added size/XL and removed size/L labels Feb 17, 2020
@tombuildsstuff
Copy link
Contributor

Ignoring a minor issue (which can be resolved OOB) the tests look ok 👍

Screenshot 2020-02-18 at 20 17 08

@tombuildsstuff tombuildsstuff changed the title F/two-oh-todo-authorization F/two-oh-todo-automation Feb 18, 2020
@tombuildsstuff tombuildsstuff merged commit d3fedb2 into master Feb 18, 2020
@tombuildsstuff tombuildsstuff deleted the f/two-oh-todo-authorization branch February 18, 2020 19:19
tombuildsstuff added a commit that referenced this pull request Feb 18, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants