Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_virtual_machine_scale_set - correct source_image_id validation #5901

Merged

Conversation

arturoera
Copy link
Contributor

@arturoera arturoera commented Feb 25, 2020

this PR applies the same fixes for linux VMs which was merged here: #5640 but for linux scalesets

@ghost ghost added the size/XS label Feb 25, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @arturoera! LGTM 👍

@katbyte katbyte added this to the v2.1.0 milestone Feb 25, 2020
@katbyte katbyte added service/vmss Virtual Machine Scale Sets and removed service/virtual-machine labels Feb 25, 2020
@katbyte katbyte changed the title fix source_image_id for linux scalesets azurerm_linux_virtual_machine_scale_set - correct source_image_id validation Feb 25, 2020
@katbyte katbyte merged commit 438c9eb into hashicorp:master Feb 25, 2020
katbyte added a commit that referenced this pull request Feb 25, 2020
@tracypholmes tracypholmes linked an issue Mar 5, 2020 that may be closed by this pull request
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@arturoera arturoera deleted the fix_linux_scalesets_source_image_id branch March 13, 2020 17:46
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/vmss Virtual Machine Scale Sets size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux VM scale set cannot be created using shared image gallery
2 participants