-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: azurerm_eventhub_namespace
#673
Conversation
Tests pass: ``` $ acctests azurerm TestAccDataSourceAzureRMEventHubNamespace_ === RUN TestAccDataSourceAzureRMEventHubNamespace_basic --- PASS: TestAccDataSourceAzureRMEventHubNamespace_basic (264.97s) === RUN TestAccDataSourceAzureRMEventHubNamespace_complete --- PASS: TestAccDataSourceAzureRMEventHubNamespace_complete (327.02s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 592.023s ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just a minor comment
|
||
keys, err := client.ListKeys(resourceGroup, name, eventHubNamespaceDefaultAuthorizationRule) | ||
if err != nil { | ||
log.Printf("[ERROR] Unable to List default keys for EventHub Namespace %q (Resource Group %q): %+v", name, resourceGroup, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this worth error-ing out completely instead of just logging? The ERROR
makes it seem like it's an issue instead of keys just not being there. Might be worth swapping to an INFO
or WARN
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good shout - I'll update this to a WARN
👍
erroring out completely doesn't make sense since it's valid that a user may have permissions to the EventHub but not the keys (AFAIK)
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Tests pass: