New Resource: azurerm_service_fabric_mesh_application
#6761
Conversation
mbfrahry
changed the title
azurerm_service_fabric_mesh_applicationazurerm_service_fabric_mesh_application
There was a problem hiding this comment.
Hey @mbfrahry, thanks for the PR.
Overall looks great however i think it might make sense to include it in the servicefabric package instead of creating a new one? And does this make sense to release without the API returning the service value?
| /* This does not currently return from the api | ||
| if err := d.Set("service", flattenServiceFabricMeshApplicationServices(resp.Services)); err != nil { | ||
| return fmt.Errorf("setting `service`: %+v", err) | ||
| }*/ |
There was a problem hiding this comment.
should this be commented out?
There was a problem hiding this comment.
It should. These attributes aren't returned from the api at the moment.
There was a problem hiding this comment.
Looks like this might be available using the ServicesClient?
There was a problem hiding this comment.
Boom, that's it. Thank you @jackofallops!
azurerm/internal/services/servicefabricmesh/resource_arm_service_fabric_mesh_application.go
Show resolved
Hide resolved
Co-authored-by: kt <kt@katbyte.me>
|
This is ready for another review @katbyte @jackofallops |
| } | ||
| } | ||
|
|
||
| // nolint: deadcode unused |
|
This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.31.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Partially addresses #2486