Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_eventhub: Adding support for CaptureDescription #681

Merged
merged 4 commits into from
Jan 11, 2018
Merged

azurerm_eventhub: Adding support for CaptureDescription #681

merged 4 commits into from
Jan 11, 2018

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 10, 2018 •
edited
Loading

Pending:

  • Support for Capture Description
  • Acceptance Test
  • Validation for the archive_name_format field
  • File a bug on the Swagger repository for the missing DataLakeSupport
  • Documentation

Tests pass:

$ acctests azurerm TestAccAzureRMEventHub_captureDescription
=== RUN   TestAccAzureRMEventHub_captureDescription
--- PASS: TestAccAzureRMEventHub_captureDescription (215.57s)
=== RUN   TestAccAzureRMEventHub_captureDescriptionDisabled
--- PASS: TestAccAzureRMEventHub_captureDescriptionDisabled (646.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	862.272s

@tombuildsstuff
azurerm_eventhub: Adding support for CaptureDescription
3534c6a 
Tests pass:

```
$ acctests azurerm TestAccAzureRMEventHub_captureDescription
=== RUN   TestAccAzureRMEventHub_captureDescription
--- PASS: TestAccAzureRMEventHub_captureDescription (215.57s)
=== RUN   TestAccAzureRMEventHub_captureDescriptionDisabled
--- PASS: TestAccAzureRMEventHub_captureDescriptionDisabled (646.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	862.272s
```
@tombuildsstuff tombuildsstuff changed the title [WIP] azurerm_eventhub: Adding support for CaptureDescription azurerm_eventhub: Adding support for CaptureDescription Jan 11, 2018
@tombuildsstuff tombuildsstuff added this to the 1.0.1 milestone Jan 11, 2018
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screen shot 2018-01-11 at 10 47 26

mbfrahry
mbfrahry approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 8833101 into master Jan 11, 2018
@tombuildsstuff tombuildsstuff deleted the eventhub-capture-description branch January 11, 2018 15:00
tombuildsstuff added a commit that referenced this pull request Jan 11, 2018
@tombuildsstuff
Updating to include #681
fdb1714
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement service/event-hubs EventHubs
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry