Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_eventgrid_domain_topic #6859

Merged
merged 5 commits into from
May 14, 2020
Merged

New Resource: azurerm_eventgrid_domain_topic #6859

merged 5 commits into from
May 14, 2020

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented May 11, 2020 •
edited
Loading

Adds new resource azurerm_eventgrid_domain_topic

Fixes #4097

@jrauschenbusch jrauschenbusch changed the title r-eventgrid-domain-topic New resource r-eventgrid-domain-topic May 11, 2020
@jrauschenbusch jrauschenbusch mentioned this pull request May 12, 2020
Closed
@jrauschenbusch jrauschenbusch changed the title New resource r-eventgrid-domain-topic New resource: azurerm_eventgrid_domain_topic May 12, 2020
@jrauschenbusch jrauschenbusch changed the title New resource: azurerm_eventgrid_domain_topic New Resource: azurerm_eventgrid_domain_topic May 12, 2020
tombuildsstuff
tombuildsstuff suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jrauschenbusch

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments then this otherwise LGTM 👍

Thanks!

azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go Show resolved Hide resolved
azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go Outdated Show resolved Hide resolved
jrauschenbusch and others added 2 commits May 13, 2020 09:37
@jrauschenbusch @tombuildsstuff
Update azurerm/internal/services/eventgrid/eventgrid_domain_topic_res…
0fa8a80 
…ource.go


fix: add `ForceNew` to enforce recreation if domain_name changes

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@jrauschenbusch
fix: remove import check
08e4396
tombuildsstuff
tombuildsstuff approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jrauschenbusch

Thanks for pushing those changes - taking a look through it appears that Travis found a few minor issues with the "ForceNew" change - since this otherwise LGTM I hope you don't mind but I'm going to push a commit to resolve the outstanding comments so that we can get this merged 👍

Thanks!

azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/eventgrid/eventgrid_domain_topic_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 13, 2020
katbyte
katbyte reviewed May 13, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the import test

azurerm/internal/services/eventgrid/tests/eventgrid_domain_topic_resource_test.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit cc979d4 into hashicorp:master May 14, 2020
katbyte added a commit that referenced this pull request May 14, 2020
@katbyte
update CHANGELOG.md to include #6859
3b56e8b
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
@jrauschenbusch jrauschenbusch deleted the r-eventgrid-topic-domain branch July 9, 2020 05:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/event-grid EventGrid size/XL
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Support for Event Grid Domain Topics and Domain-Scope Event Subscriptions
4 participants
@jrauschenbusch @tombuildsstuff @katbyte @manicminer