Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_storage_account - Support RAGZRS and GZRS account_replication_type #7080

Merged
merged 3 commits into from
May 28, 2020
Merged

azurerm_storage_account - Support RAGZRS and GZRS account_replication_type #7080

merged 3 commits into from
May 28, 2020

Conversation

lrxtom2
Copy link
Contributor

@lrxtom2 lrxtom2 commented May 26, 2020

Fixes #7051

tombuildsstuff
tombuildsstuff suggested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lrxtom2

Thanks for this PR - I've taken a look through and left some comments inline but if we can add some tests then this otherwise looks good 👍

Thanks!

azurerm/internal/services/storage/resource_arm_storage_account.go Show resolved Hide resolved
website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
@lrxtom2 @tombuildsstuff
Update website/docs/r/storage_account.html.markdown
174f13d 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@WodansSon WodansSon added this to the v2.12.0 milestone May 27, 2020
@WodansSon WodansSon changed the title Support RAGZRS and GZRS in account_replication_type in strage_account azurerm_storage_account - Support RAGZRS and GZRS account_replication_type May 27, 2020
@ghost ghost added size/M and removed size/XS labels May 28, 2020
@lrxtom2
Copy link
Contributor Author

lrxtom2 commented May 28, 2020

@tombuildsstuff Thanks for your comments! Updated testcase there.

@ghost ghost removed the waiting-response label May 28, 2020
@lrxtom2 lrxtom2 requested a review from tombuildsstuff May 28, 2020 16:53
katbyte
katbyte approved these changes May 28, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lrxtom2~ LGTM 👍

@katbyte katbyte merged commit 3d15d24 into hashicorp:master May 28, 2020
katbyte added a commit that referenced this pull request May 28, 2020
@katbyte
update CHANGELOG.md to include #7080
a3c542d
@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

@lrxtom2 lrxtom2 deleted the storage_geo branch May 29, 2020 02:13
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@lrxtom2 @pbrit
azurerm_storage_account - Support RAGZRS and GZRS `account_replicat…
c944974 
…ion_type` (hashicorp#7080)

Fixes hashicorp#7051
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@katbyte @pbrit
update CHANGELOG.md to include hashicorp#7080
c79f46f
@ghost
Copy link

ghost commented Jun 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation enhancement service/storage size/M
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging this pull request may close these issues.

azurerm_storage_account account_replication_type GZRS
4 participants
@lrxtom2 @tombuildsstuff @katbyte @WodansSon