Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Container/Share retry create if 409 && beingdeleted #7179

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

nickmhankins
Copy link
Contributor

Fixes #6803

@ghost ghost added the size/S label Jun 3, 2020
@ghost ghost added size/M and removed size/S labels Jul 13, 2020
@jackofallops
Copy link
Member

Hi @nickmhankins

Thanks for the effort on identifying this and the work on addressing it.

I hope you don't mind, but I changed the code to a poller pattern we use to check state, rather than a flat 300s pause and added some tests that exhibit the issue identified to check the code works correctly. They're passing locally for me, so I'm just running them on our CI system. As soon as they're green and Travis is happy I'll get this merged.

Thanks again!

@jackofallops jackofallops self-assigned this Jul 13, 2020
@jackofallops jackofallops added this to the v2.19.0 milestone Jul 13, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

@jackofallops
Copy link
Member

Tests passing:
image

@jackofallops jackofallops merged commit e31eb93 into hashicorp:master Jul 13, 2020
jackofallops added a commit that referenced this pull request Jul 13, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete and immediately recreate a storage container
4 participants