-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended EventGrid event subscription webhook support #7207
Extended EventGrid event subscription webhook support #7207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jrauschenbusch
Thanks for this PR - taking a look through this LGTM, would you mind rebasing this and then we should be able to kick off the tests/get this merged 👍
Thanks!
7b79ca8
to
cedcffe
Compare
@tombuildsstuff I've rebased everything. Ready to get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jrauschenbusch
Thanks for pushing those changes - taking a look through if we can add documentation for the base_url
field then this otherwise LGTM 👍
Thanks!
@tombuildsstuff I've added the documentation. Please review and ping me back if it LGTY. |
This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.14.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Extended webhook configuration options for resource
azurerm_eventgrid_event_subscription
.