Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_traffic_manager_profile - Updating of the profile no longer destroys all the endpoints #7846

Merged
merged 7 commits into from
Aug 11, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Jul 22, 2020

Fixes #6041
Supersedes #7471

Special thanks to @nitzanm

I also updated the test cases, since the relative_name in dns_config block is a ForceNew attribute, therefore it makes no sense to change in an update test case.

@ghost ghost added the size/L label Jul 22, 2020
@ArcturusZhang ArcturusZhang changed the title Update azurerm_traffic_manager_profile - Support in-place update Update azurerm_traffic_manager_profile - Updating of the profile no longer destroys all the endpoints Jul 22, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit eb87afb into hashicorp:master Aug 11, 2020
katbyte added a commit that referenced this pull request Aug 11, 2020
@ArcturusZhang ArcturusZhang deleted the pr/7471 branch August 11, 2020 06:21
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to azurerm_traffic_manager_profile destroys endpoints
3 participants