Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading containerservice API to 2020-04-01 to support new AKS features #7894

Merged

Conversation

jmcshane
Copy link
Contributor

Upgrade to support surge parameter for #7892

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @jmcshane

@tombuildsstuff tombuildsstuff force-pushed the feature/upgrade-containerservice branch from da0f72e to 0e1448b Compare August 10, 2020 11:12
@tombuildsstuff
Copy link
Contributor

@jmcshane hope you don't mind but I've rebased this on top of master to fix up the merge conflicts so that we can get this merged 👍

@jmcshane
Copy link
Contributor Author

@tombuildsstuff looks like the CI failures are just on intermittent issues. Anything else I need to take a look at for this PR?

@tombuildsstuff
Copy link
Contributor

@jmcshane all good - I've been waiting for the AKS tests to run overnight, since they take a while - re-triggered Travis now :)

@tombuildsstuff tombuildsstuff merged commit f5b9d1c into hashicorp:master Aug 11, 2020
tombuildsstuff added a commit that referenced this pull request Aug 11, 2020
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants