-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_api_management_subscription
- Support allow_tracing property
#7969
azurerm_api_management_subscription
- Support allow_tracing property
#7969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @BlakeDickie
Thanks for this PR - apologies for the delayed review here!
Taking a look through this is looking good - if we can add an acceptance test for this then this otherwise LGTM 👍
Thanks!
Type: schema.TypeBool, | ||
Optional: true, | ||
Default: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add an acceptance covering setting, and enabling/disabling this field - we should be able to add this to the 'update' test to confirm this works
@tombuildsstuff No worries. I've added some acceptance tests for ensuring the new property defaults correctly and can be set to both true/false explicitly. It's my first time in this code base, so let me know if there's any tweaks that are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @BlakeDickie
Thanks for pushing those changes - I've taken a look through and if we can fix the one comment/issue then this otherwise LGTM 👍
Thanks!
azurerm/internal/services/apimanagement/api_management_subscription_resource.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @BlakeDickie 👍
azurerm_api_management_subscription
- Support allow_tracing property
This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.26.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Resolves #7968
allow_tracing
as a property on theazurerm_api_management_subscription
resource.true
to match the current state of the flag when subscriptions are created before this change.